DM-43347: Configure visit-level refcat match analysis tools tasks for ComCamSim #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctslater
reviewed
Mar 21, 2024
| @@ -0,0 +1,3 @@ | |||
| """comCamSim-specific overrides for RefCatSourcePhotometricAnalysisTask""" | |||
|
|
|||
| config.connections.data = "sourceTable_visit_uw_stars_20240228_photoMatch" | |||
There was a problem hiding this comment.
I don't know the details here but just to double check, is this supposed to end in _photoMatch or _match? I don't see this datset type in /repo/ops-rehearsal-3-prep.
There was a problem hiding this comment.
After Sophie's ticket in Dec, the astrometry match tasks use the old names and the photometry one adds the word photo or Photometric in front of everything. This is the one I commented on the PR that it doesn't run. Necessary but not sufficient. I was hoping to get some help from @sr525 during pair coding today. Maybe someone else can get it going in the next week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RefCatSourcePhotometricAnalysisTask one, as of now is necessary, but not sufficient.